lkml.org 
[lkml]   [2022]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] trace: Fix some checker warnings
On Mon, 5 Dec 2022 12:11:19 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> > #if (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \
> > || defined(CONFIG_OSNOISE_TRACER)) && defined(CONFIG_FSNOTIFY)
> > #define LATENCY_FS_NOTIFY
> > +#define USES_MAX_TRACE
> > #endif
> >
> > And use that instead.
>
> BTW, why can't HWLAT_TRACER and OSNOISE_TRACER depend on TRACER_MAX_TRACE?
> I think it is better to reduce combinations of those, especially partially
> enabling a feature seems a bit dangerous.

Well, the issue with that is that if the TRACER_MAX_TRACE is off
(because it's not something commonly selected), it will hide osnoise
and hwlat from showing up in the menus.

-- Steve

\
 
 \ /
  Last update: 2022-12-05 04:30    [W:0.099 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site