[lkml]   [2022]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[RFC PATCH v3 0/4] vsock: update tools and error handling
Patchset consists of two parts:

1) Kernel patch
One patch from Bobby Eshleman. I took single patch from Bobby: and use only part for
af_vsock.c, as VMCI and Hyper-V parts were rejected.

I used it, because for SOCK_SEQPACKET big messages handling was broken -
ENOMEM was returned instead of EMSGSIZE. And anyway, current logic which
always replaces any error code returned by transport to ENOMEM looks
strange for me also(for example in EMSGSIZE case it was changed to

2) Tool patches
Since there is work on several significant updates for vsock(virtio/
vsock especially): skbuff, DGRAM, zerocopy rx/tx, so I think that this
patchset will be useful.

This patchset updates vsock tests and tools a little bit. First of all
it updates test suite: two new tests are added. One test is reworked
message bound test. Now it is more complex. Instead of sending 1 byte
messages with one MSG_EOR bit, it sends messages of random length(one
half of messages are smaller than page size, second half are bigger)
with random number of MSG_EOR bits set. Receiver also don't know total
number of messages. Message bounds control is maintained by hash sum
of messages length calculation. Second test is for SOCK_SEQPACKET - it
tries to send message with length more than allowed. I think both tests
will be useful for DGRAM support also.

Third thing that this patchset adds is small utility to test vsock
performance for both rx and tx. I think this util could be useful as
'iperf', because:
1) It is small comparing to 'iperf()', so it very easy to add new
mode or feature to it(especially vsock specific).
2) It is located in kernel source tree, so it could be updated by the
same patchset which changes related kernel functionality in vsock.

I used this util very often to check performance of my rx zerocopy
support(this tool has rx zerocopy support, but not in this patchset).

Patchset was rebased and tested on skbuff v5 patch from Bobby Eshleman:

v2 -> v3:
- Patches for VMCI and Hyper-V were removed from patchset(commented by
Vishnu Dasa and Dexuan Cui)
- In message bounds test hash is computed from data buffer with random
content(in v2 it was size only). This approach controls both data
integrity and message bounds.
- vsock_perf:
- grammar fixes
- only long parameters supported(instead of only short)
v1 -> v2:
- Three new patches from Bobby Eshleman to kernel part
- Message bounds test: some refactoring and add comment to describe
hashing purpose
- Big message test: check 'errno' for EMSGSIZE and move new test to
the end of tests array
- vsock_perf:
- update README file
- add simple usage example to commit message
- update '-h' (help) output
- use 'stdout' for output instead of 'stderr'
- use 'strtol' instead of 'atoi'

Bobby Eshleman(1):
vsock: return errors other than -ENOMEM to socket

Arseniy Krasnov(3):
test/vsock: rework message bound test
test/vsock: add big message test
test/vsock: vsock_perf utility

net/vmw_vsock/af_vsock.c | 3 +-
tools/testing/vsock/Makefile | 1 +
tools/testing/vsock/README | 34 +++
tools/testing/vsock/control.c | 28 +++
tools/testing/vsock/control.h | 2 +
tools/testing/vsock/util.c | 13 ++
tools/testing/vsock/util.h | 1 +
tools/testing/vsock/vsock_perf.c | 449 +++++++++++++++++++++++++++++++++++++++
tools/testing/vsock/vsock_test.c | 193 +++++++++++++++--
9 files changed, 710 insertions(+), 14 deletions(-)
 \ /
  Last update: 2022-12-04 20:18    [W:0.085 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site