Messages in this thread | | | From | Anand Moon <> | Date | Wed, 28 Dec 2022 20:14:26 +0530 | Subject | Re: [PATCH v1 03/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2 |
| |
Hi Martin,
On Wed, 28 Dec 2022 at 18:21, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > Hi Anand, > Thanks for your review comments.
> thank you for working on this topic! > > On Wed, Dec 28, 2022 at 11:05 AM Anand Moon <linux.amoon@gmail.com> wrote: > [...] > > + usb { > > + dr_mode = "host"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + hub@1 { > > + /* Genesys Logic GL852G-OHG usb hub */ > > + compatible = "genesys,usb5e3,610"; > > + reg = <1>; > > + vdd-supply = <&usb_otg_pwr>; > > + reset-gpio = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>; > > + }; > > + }; > My understanding is that the hub@1 node should be part of the > corresponding USB controller node, not a new node. > In this case hub@1 should go into the existing &usb1 node. That way we > describe the way the hardware is set up (meaning: hub@1 is connected > to &usb1). >
Ok, I will move this code under &usb0 and &usb1 nodes.
onboard_usb_hub module just assists in usb hub reset. so these changes are meant to replace the gpio-hog.
$ dmesg | grep onboard [ 5.405558] usbcore: registered new device driver onboard-usb-hub [ 6.383428] onboard-usb-hub 1-1: reset high-speed USB device number 2 using dwc2
Here is the boot log of the odroid c2 [0] https://pastebin.com/PFy5waPb
> In case hub@1 is not detected within &usb1 then you may need something > like [0] (not tested for your use-case). > If that helps: feel free to include that patch in your series. >
Thanks, will check if this is needed in this case. As of now it just reinitializes the hub.
> > Best regards, > Martin > > > [0] https://github.com/xdarklight/linux/commit/d8b96e5bc9c20ab2585194e0e59580c3b062c431
Thanks -Anand
| |