Messages in this thread | | | From | Martin Blumenstingl <> | Date | Wed, 28 Dec 2022 13:51:32 +0100 | Subject | Re: [PATCH v1 03/11] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2 |
| |
Hi Anand,
thank you for working on this topic!
On Wed, Dec 28, 2022 at 11:05 AM Anand Moon <linux.amoon@gmail.com> wrote: [...] > + usb { > + dr_mode = "host"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + hub@1 { > + /* Genesys Logic GL852G-OHG usb hub */ > + compatible = "genesys,usb5e3,610"; > + reg = <1>; > + vdd-supply = <&usb_otg_pwr>; > + reset-gpio = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>; > + }; > + }; My understanding is that the hub@1 node should be part of the corresponding USB controller node, not a new node. In this case hub@1 should go into the existing &usb1 node. That way we describe the way the hardware is set up (meaning: hub@1 is connected to &usb1).
In case hub@1 is not detected within &usb1 then you may need something like [0] (not tested for your use-case). If that helps: feel free to include that patch in your series.
Best regards, Martin
[0] https://github.com/xdarklight/linux/commit/d8b96e5bc9c20ab2585194e0e59580c3b062c431
| |