lkml.org 
[lkml]   [2022]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] KVM: x86: fix deadlock for KVM_XEN_EVTCHN_RESET
On 12/28/22 12:55, Woodhouse, David wrote:
>
> IIRC the send_port and type aren't used from hcall_send so we could
> stick those in a union with a 'next' pointer and use it to build a list
> instead of having to allocate the array (pathological worst case 32KiB).

Yeah I thought about using a list. The union is doable as you say, but
I wasn't sure if things were going to change in kvm_xen_evtchn_send later.

And the worst case is order 3, which is within PAGE_ALLOC_COSTLY_ORDER,
so I decided to go with the array which only consumes memory on reset
rather than always; it's much more likely that the array will be smaller
than a page.

Paolo

> Or if the union is a bit icky, we could just add the 'next' pointer
> unconditionally.
>

\
 
 \ /
  Last update: 2023-03-26 23:22    [W:0.029 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site