lkml.org 
[lkml]   [2022]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH net v2 0/3] net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers
Date
This series fixes a potential NULL dereference in ethtool_get_phy_stats
while also attempting to refactor/split said function into multiple
helpers so that it's easier to reason about what's going on.

I've taken Andrew Lunn's suggestions on the previous version of this
patch and added a bit of my own.

Changes since v1:
- Remove an extra newline in the first patch
- Move WARN_ON_ONCE into the if check as it already returns the
result of the comparison
- Actually split ethtool_get_phy_stats instead of attempting to
refactor it

Daniil Tatianin (3):
net/ethtool/ioctl: return -EOPNOTSUPP if we have no phy stats
net/ethtool/ioctl: remove if n_stats checks from ethtool_get_phy_stats
net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers

net/ethtool/ioctl.c | 107 +++++++++++++++++++++++++++++---------------
1 file changed, 70 insertions(+), 37 deletions(-)

--
2.25.1

\
 
 \ /
  Last update: 2023-03-26 23:20    [W:0.034 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site