[lkml]   [2022]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v2 0/2] convert i915_active.count from atomic_t to refcount_t
Transition the reference count member variable count of struct i915_active from
atomic_t type to refcount_t type. This proposal is based on issues identified
using the atomic_as_refcounter.cocci Coccinelle semantic patch script.

Patch 1/2: proposes to convert the base implementation of variable count from
atomic_t to refcount_t. This also includes the transition of
atomic_*() API calls to their equivalent refcount_*() API calls.

Patch 2/2: proposes to transition the atomic_*() API calls in i915 selftest
use cases to their equivalent refcount_*() API calls.

Please Note:
1. Patch 1/2 should be applied before patch 2/2 due to interdependency.
2. I did not enable to the selftest and debug configurations earlier while
building the i915 base driver. With the build failures reported by the
Kernel Test Robot, I have now included those changes. I did not find any
other configurations that required additional atomic_* API call transition
for this member variable of struct i915_active. Please let me know if there
are other related disabled configurations that I should be enable for
additional code coverage.
3. Any guidance on working with i915/selftests would be very helpful for my

Changes in v2:
1. Patch series introduced.
2. Handle build issues Reported-by: kernel test robot <>
Earlier a standalone patch was sent for the i915 base driver only. The
Kernel Test Robot reported failure for additional atomic_*() calls specific
to i915 debugging support when enabled. This version now includes those
changes as well.
3. Handle build issues Reported-by: kernel test robot <> for i915/selftests
Include changes for i915/selftests use cases for atomic_* to refcount_*

Deepak R Varma (2):
drm/i915: convert i915_active.count from atomic_t to refcount_t
drm/i915/selftests: Convert atomic_* API calls for i915_active.count

drivers/gpu/drm/i915/i915_active.c | 28 +++++++++++---------
drivers/gpu/drm/i915/i915_active.h | 6 ++---
drivers/gpu/drm/i915/i915_active_types.h | 4 +--
drivers/gpu/drm/i915/selftests/i915_active.c | 8 +++---
4 files changed, 24 insertions(+), 22 deletions(-)


 \ /
  Last update: 2023-03-26 23:19    [W:0.125 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site