lkml.org 
[lkml]   [2022]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE()
On Tue, Dec 20, 2022 at 06:56:38PM +0000, Lorenzo Stoakes wrote:
> On Tue, Dec 20, 2022 at 06:53:18PM +0000, Lorenzo Stoakes wrote:
> [snip
> > Absolutely in favour of this in principle (BUG_ON() is something we should
> > resort to in only the direst of circumstances), one small nit - perhaps it'd be
> > neater to simply make this a guard clause? E.g.:-
> >
> > if (!WARN_ON_ONCE(!va))
> > return;
> >
> > ...
>
> Made a mistake here, meant to say
>
> if (WARN_ON_ONCE(!va))
> return;
>
Agree. This looks better. Less confusing :)

I will post a v2.

--
Uladzislau Rezki

\
 
 \ /
  Last update: 2023-03-26 23:16    [W:0.036 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site