lkml.org 
[lkml]   [2022]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE()
On Tue, Dec 20, 2022 at 06:53:18PM +0000, Lorenzo Stoakes wrote:
[snip
> Absolutely in favour of this in principle (BUG_ON() is something we should
> resort to in only the direst of circumstances), one small nit - perhaps it'd be
> neater to simply make this a guard clause? E.g.:-
>
> if (!WARN_ON_ONCE(!va))
> return;
>
> ...

Made a mistake here, meant to say

if (WARN_ON_ONCE(!va))
return;

Of course :)

Apologies, only just noticed you are sending a v2, perhaps something to consider
for it? But will hold off further review until you send it! :)

\
 
 \ /
  Last update: 2023-03-26 23:16    [W:0.322 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site