Messages in this thread | | | Date | Tue, 20 Dec 2022 15:55:22 +0100 | Subject | Re: [PATCH 6/6] dt-bindings: regulator: add MAX77659 regulator binding | From | Krzysztof Kozlowski <> |
| |
On 20/12/2022 14:22, Zeynep Arslanbenzer wrote: > This patch adds device tree binding documentation for MAX77659 regulator.
Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> > Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@analog.com> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > --- > .../regulator/adi,max77659-regulator.yaml | 31 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77659-regulator.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/adi,max77659-regulator.yaml b/Documentation/devicetree/bindings/regulator/adi,max77659-regulator.yaml > new file mode 100644 > index 000000000000..c1e2d88be25b > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/adi,max77659-regulator.yaml > @@ -0,0 +1,31 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/adi,max77659-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Regulator driver for MAX77659 PMIC from ADI.
It's not a driver. Drop. Also full stop
> + > +maintainers: > + - Nurettin Bolucu <Nurettin.Bolucu@analog.com> > + - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > + > +description: | > + This module is part of the MAX77659 MFD device. For more details > + see Documentation/devicetree/bindings/mfd/adi,max77659.yaml. > + > + The regulator is represented as a sub-node of the PMIC node on the device tree. > + > +properties: > + compatible: > + const: adi,max77650-regulator > + > + regulator-boot-on: true > + regulator-always-on: true > +
Missing reference to regulator schema.
Best regards, Krzysztof
| |