Messages in this thread | | | Date | Tue, 20 Dec 2022 15:54:10 +0100 | Subject | Re: [PATCH 4/6] dt-bindings: power: supply: add MAX77659 charger binding | From | Krzysztof Kozlowski <> |
| |
On 20/12/2022 14:22, Zeynep Arslanbenzer wrote: > This patch adds device tree binding documentation for MAX77659 charger.
Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> > Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@analog.com> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > --- > .../power/supply/adi,max77659-charger.yaml | 42 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/adi,max77659-charger.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/adi,max77659-charger.yaml b/Documentation/devicetree/bindings/power/supply/adi,max77659-charger.yaml > new file mode 100644 > index 000000000000..24f8b5a2bd84 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/adi,max77659-charger.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/adi,max77659-charger.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Battery charger for MAX77659 PMIC from ADI.
Drop full stop.
> + > +maintainers: > + - Nurettin Bolucu <Nurettin.Bolucu@analog.com> > + - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com> > + > +description: | > + This module is part of the MAX77659 MFD device. For more details > + see Documentation/devicetree/bindings/mfd/adi,max77659.yaml. > + > + The charger is represented as a sub-node of the PMIC node on the device tree. > + > +properties: > + compatible: > + const: adi,max77659-charger > + > + reg: > + maxItems: 1 > + > + adi,fast-charge-timer: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Fast-charge safety timer value (in hours).
No, use suffixes for common units.
> + > + adi,fast-charge-microamp: > + description: Fast-charge constant current value.
> + > + adi,topoff-timer: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Top-Off timer value (in minutes).
No, use suffixes for common units.
Best regards, Krzysztof
| |