Messages in this thread | | | Date | Tue, 20 Dec 2022 14:02:17 +0100 | Subject | Re: [PATCH v1 4/9] media: verisilicon: Check AV1 bitstreams bit depth | From | Benjamin Gaignard <> |
| |
Le 19/12/2022 à 21:38, Nicolas Dufresne a écrit : > Le lundi 19 décembre 2022 à 16:56 +0100, Benjamin Gaignard a écrit : >> The driver supports 8 and 10 bits bitstreams, make sure to discard >> other cases. >> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> >> --- >> drivers/media/platform/verisilicon/hantro_drv.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/media/platform/verisilicon/hantro_drv.c >> index 8e93710dcfed..e10fc59634dd 100644 >> --- a/drivers/media/platform/verisilicon/hantro_drv.c >> +++ b/drivers/media/platform/verisilicon/hantro_drv.c >> @@ -282,7 +282,13 @@ static int hantro_try_ctrl(struct v4l2_ctrl *ctrl) >> /* We only support profile 0 */ >> if (dec_params->profile != 0) >> return -EINVAL; >> + } else if (ctrl->id == V4L2_CID_STATELESS_AV1_SEQUENCE) { >> + const struct v4l2_ctrl_av1_sequence *sequence = ctrl->p_new.p_av1_sequence; >> + >> + if (sequence->bit_depth != 8 && sequence->bit_depth != 10) >> + return -EINVAL; > As you state in the cover letter, should this just be this for now ?
The driver can decode 8 or 10 bits bitstreams but will on produce 8bits (NV12_4L4 or NV12) frames. The hardware is able to truncate 10bits bitstreams to 8 bits output.
> > >> + if (sequence->bit_depth != 8) >> + return -EINVAL; > >> } >> + >> return 0; >> } >>
| |