lkml.org 
[lkml]   [2022]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Patch V1 2/7] x86/microcode/intel: Remove retries on early microcode load
From
On 11/29/2022 1:08 PM, Ashok Raj wrote:
> -
> - if (apply_microcode_early(&uci, true)) {
> - /* Mixed-silicon system? Try to refetch the proper patch: */
> - *iup = NULL;
> -
> - goto reget;
> - }
> + apply_microcode_early(&uci, true);

After this change, none of the callers of apply_microcode_early() check
the return code.

In future, do we expect callers to care about the return code? The rest
patches in this series don't seem to suggest so. Also, the expected
error printing happens in the function itself.

Should the return type for apply_microcode_early() be changed to void
(in a follow-up patch)?

Sohil

\
 
 \ /
  Last update: 2022-12-03 00:55    [W:0.255 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site