Messages in this thread | | | Date | Fri, 2 Dec 2022 12:57:23 -0800 | Subject | Re: [Patch V1 3/7] x86/microcode/core: Move microcode_check() to cpu/microcode/core.c | From | Sohil Mehta <> |
| |
On 11/29/2022 1:08 PM, Ashok Raj wrote: > microcode_check() is only called from microcode/core.c. Move it and make > it static to prepare for upcoming fix of false negative when checking CPU > features after a microcode update.
Should we use this opportunity to also make the function name a bit more descriptive? microcode_check() seems very ambiguous to a first time reader.
> +/* > + * The microcode loader calls this upon late microcode load to recheck features, > + * only when microcode has been updated. Caller holds microcode_mutex and CPU > + * hotplug lock. > + */ > +static void microcode_check(void)
How about, microcode_recheck_features() or simply recheck_features() since it is static now?
Sohil
| |