Messages in this thread | | | Date | Mon, 19 Dec 2022 07:03:49 +0100 | Subject | Re: [RESEND v12 4/4] phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY support | From | Marek Vasut <> |
| |
On 12/19/22 04:25, Hongxing Zhu wrote:
Hi,
>>> @@ -238,6 +251,14 @@ static int imx8_pcie_phy_probe(struct >> platform_device *pdev) >>> return PTR_ERR(imx8_phy->reset); >>> } >>> >>> + if (imx8_phy->drvdata->variant == IMX8MP) { >>> + imx8_phy->perst = >>> + devm_reset_control_get_exclusive(dev, "perst"); >>> + if (IS_ERR(imx8_phy->perst)) >>> + dev_err_probe(dev, PTR_ERR(imx8_phy->perst), >> >> I just notice this , are we missing return here ? >> >> That is ... return dev_err_probe(...) ? > > Ooh, it's my fault. Thanks for your reminder. > One return should be here. > - dev_err_probe(dev, PTR_ERR(imx8_phy->perst), > + return dev_err_probe(dev, PTR_ERR(imx8_phy->perst), > Hi Vinod @vkoul@kernel.org: > Should I re-summit one fix patch?
I think just send a follow up patch with Fixes: tag .
| |