Messages in this thread |  | | Date | Sat, 17 Dec 2022 20:46:31 +0100 | Subject | Re: [RESEND v12 4/4] phy: freescale: imx8m-pcie: Add i.MX8MP PCIe PHY support | From | Marek Vasut <> |
| |
On 10/13/22 03:47, Richard Zhu wrote:
Hi,
[...]
> @@ -238,6 +251,14 @@ static int imx8_pcie_phy_probe(struct platform_device *pdev) > return PTR_ERR(imx8_phy->reset); > } > > + if (imx8_phy->drvdata->variant == IMX8MP) { > + imx8_phy->perst = > + devm_reset_control_get_exclusive(dev, "perst"); > + if (IS_ERR(imx8_phy->perst)) > + dev_err_probe(dev, PTR_ERR(imx8_phy->perst),
I just notice this , are we missing return here ?
That is ... return dev_err_probe(...) ?
> + "Failed to get PCIE PHY PERST control\n"); > + }
[...]
|  |