lkml.org 
[lkml]   [2022]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 10/20] gunyah: rsc_mgr: Add resource manager RPC core
From


On 12/12/2022 10:26 PM, Greg Kroah-Hartman wrote:
> On Mon, Dec 12, 2022 at 03:46:53PM -0800, Elliot Berman wrote:
>>
>> Reference counting is not needed on the gh_rm_rpc object because its only
>> client (the VM manager) is torn down before the gh_rm_rpc.
>
> So again, who controls the lifecycle of it? Where is the reference
> count for the structure as it is pointing to reference counted memory?

Had some internal review and I think I'm now taking better care of this
(and the device situation in the other mail). I will send out next
revision soon.

In summary:

- Incrementing platform device's refcount when creating a new VM since
it spawns new file descriptor that could remain open after closing the
main miscdevice.
- Re-organizing vm_manager so it is much more like a library than a
separate device.

Thanks,
Elliot

\
 
 \ /
  Last update: 2022-12-16 03:26    [W:0.120 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site