Messages in this thread Patch in this message | | | Date | Fri, 2 Dec 2022 10:42:04 +0800 (CST) | From | <> | Subject | [PATCH linux-next v2] pxa: Remove dev err() after platform get irq() |
| |
From: zhang songyi <zhang.songyi@zte.com.cn>
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure.
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn> Reviewed-by: Lubomir Rintel <lkundrak@v3.sk> --- drivers/soc/pxa/ssp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c index 93449fb3519e..bd029e838241 100644 --- a/drivers/soc/pxa/ssp.c +++ b/drivers/soc/pxa/ssp.c @@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev) }
ssp->irq = platform_get_irq(pdev, 0); - if (ssp->irq < 0) { - dev_err(dev, "no IRQ resource defined\n"); + if (ssp->irq < 0) return -ENODEV; - }
if (dev->of_node) { const struct of_device_id *id = -- 2.15.2
| |