Messages in this thread | | | Date | Tue, 8 Nov 2022 16:24:00 +0100 | Subject | Re: [PATCH v2 2/3] arm: dts: nuvoton: npcm7xx: add sgpio node | From | Krzysztof Kozlowski <> |
| |
On 08/11/2022 10:28, Jim Liu wrote: > Add the SGPIO controller to the NPCM750 devicetree > > Signed-off-by: Jim Liu <JJLIU0@nuvoton.com> > --- > Changes for v2: > - modify dts node > --- > arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > index c7b5ef15b716..9cac60734b57 100644 > --- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > +++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi > @@ -330,6 +330,36 @@ > status = "disabled"; > }; > > + sgpio1: sgpio@101000 {
Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "nuvoton,npcm750-sgpio"; > + reg = <0x101000 0x200>; > + clocks = <&clk NPCM7XX_CLK_APB3>; > + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>; > + bus-frequency = <16000000>; > + gpio-controller; > + #gpio-cells = <2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&iox1_pins>; > + nin_gpios = <64>; > + nout_gpios = <64>; > + status = "disabled";
Why? What is missing from external resources?
> + }; > + > + sgpio2: sgpio@102000 {
Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "nuvoton,npcm750-sgpio"; > + reg = <0x102000 0x200>; > + clocks = <&clk NPCM7XX_CLK_APB3>; > + interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>; > + bus-frequency = <16000000>; > + gpio-controller; > + #gpio-cells = <2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&iox2_pins>; > + nin_gpios = <64>; > + nout_gpios = <64>; > + status = "disabled";
Why? What is missing from external resources?
Best regards, Krzysztof
| |