Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 8 Nov 2022 14:02:50 +0100 | Subject | Re: [PATCH v2 1/3] gpio:gpio-npcm-sgpio: Add Nuvoton sgpio driver |
| |
Hi Jim!
thanks for your patch!
On Tue, Nov 8, 2022 at 10:29 AM Jim Liu <jim.t90615@gmail.com> wrote:
> Add Nuvoton BMC sgpio driver support. > > Signed-off-by: Jim Liu <JJLIU0@nuvoton.com> > --- > Changes for v2: > - add prefix > - write the enum values in all capitals > - remove _init in npcm_sgpio_probe
Overall this looks very good.
But:
> + u8 nin_sgpio; > + u8 nout_sgpio;
These seem to be software constructs, for which you also add custom device tree bindings.
The purpose seems to be an extra layer of protection, such as blocking a user from setting some GPIOs as input or output.
I think you should just remove this, the GPIO driver is already sufficiently low level without the need of protecting the users from themselves.
Yours, Linus Walleij
| |