Messages in this thread | | | From | Ian Rogers <> | Date | Tue, 8 Nov 2022 15:16:02 -0800 | Subject | Re: [PATCH 3/9] perf stat: Clear screen only if output file is a tty |
| |
On Mon, Nov 7, 2022 at 1:33 PM Namhyung Kim <namhyung@kernel.org> wrote: > > The --interval-clear option makes perf stat to clear the terminal at > each interval. But it doesn't need to clear the screen when it saves > to a file.
Would it be more intuitive to warn if interval-clear is specified with a file?
Thanks, Ian
> Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/util/stat-display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index 17d656566cd9..d4936a502560 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -892,7 +892,7 @@ static void print_interval(struct perf_stat_config *config, > FILE *output = config->output; > static int num_print_interval; > > - if (config->interval_clear) > + if (config->interval_clear && isatty(fileno(output))) > puts(CONSOLE_CLEAR); > > if (!config->iostat_run && !config->json_output) > -- > 2.38.1.431.g37b22c650d-goog >
| |