lkml.org 
[lkml]   [2022]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 9/9] perf stat: Consolidate condition to print metrics
    On Mon, Nov 7, 2022 at 1:33 PM Namhyung Kim <namhyung@kernel.org> wrote:
    >
    > The pm variable holds an appropriate function to print metrics for CSV
    > anf JSON already. So we can combine the if statement to simplify the
    > code a little bit. This also matches to the above condition for non-CSV
    > and non-JSON case.
    >
    > Signed-off-by: Namhyung Kim <namhyung@kernel.org>

    Acked-by: Ian Rogers <irogers@google.com>

    Thanks,
    Ian

    > ---
    > tools/perf/util/stat-display.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
    > index a10af26c26ab..4d3999673dde 100644
    > --- a/tools/perf/util/stat-display.c
    > +++ b/tools/perf/util/stat-display.c
    > @@ -600,9 +600,7 @@ static void printout(struct perf_stat_config *config, struct aggr_cpu_id id, int
    > pm(config, &os, NULL, NULL, "", 0);
    > print_noise(config, counter, noise);
    > print_running(config, run, ena);
    > - if (config->csv_output)
    > - pm(config, &os, NULL, NULL, "", 0);
    > - else if (config->json_output)
    > + if (config->csv_output || config->json_output)
    > pm(config, &os, NULL, NULL, "", 0);
    > return;
    > }
    > --
    > 2.38.1.431.g37b22c650d-goog
    >

    \
     
     \ /
      Last update: 2022-11-09 00:25    [W:3.526 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site