lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v11 2/2] arm64: dts: qcom: sagit: add initial device tree for sagit
From
On 07/11/2022 15:24, Dzmitry Sankouski wrote:
> Is the master branch of
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> proper rebase?

Yes, next/master is ok.

> Or do I need to search and apply device tree doc patches somehow
> before running dtbs_check?
> I rebased on linux-next/master, and my dts is ok.
>
> A lot of warnings for msm8998.dtsi, though. I think it should be fixed
> in a separate patch series.

Your DTS is not OK and it introduces wrong pinctrl entry, which I
commented under. It also does not pass test, as I said:

DTC_CHK arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dtb
/home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dtb:
pinctrl@3400000: blsp1-uart3-on-state: 'oneOf' conditional failed, one
must be fixed:
'function' is a required property
'pins' is a required property
'cts', 'cts-pins', 'rfr-pins', 'rx', 'rx-pins', 'tx-pins' do not match
any of the regexes: 'pinctrl-[0-9]+'
'cts', 'rx' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
From schema:
/home/krzk/dev/linux/linux/Documentation/devicetree/bindings/pinctrl/qcom,msm8998-pinctrl.yaml
make[1]: Leaving directory '/home/krzk/dev/linux/linux/out'


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-11-07 15:35    [W:0.848 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site