lkml.org 
[lkml]   [2022]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v11 2/2] arm64: dts: qcom: sagit: add initial device tree for sagit
    From
    On 02/11/2022 11:55, Dzmitry Sankouski wrote:
    > New device support - Xiaomi Mi6 phone
    >
    > What works:
    > - storage
    > - usb
    > - power regulators
    >
    > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
    > ---

    (...)

    > +
    > +&blsp1_i2c5_sleep {
    > + /delete-property/ bias-pull-up;
    > + bias-disable;
    > +};
    > +
    > +&blsp1_uart3 {
    > + status = "okay";
    > +
    > + bluetooth {
    > + compatible = "qcom,wcn3990-bt";
    > +
    > + vddio-supply = <&vreg_s4a_1p8>;
    > + vddxo-supply = <&vreg_l7a_1p8>;
    > + vddrf-supply = <&vreg_l17a_1p3>;
    > + vddch0-supply = <&vreg_l25a_3p3>;
    > + max-speed = <3200000>;
    > + };
    > +};
    > +
    > +&blsp1_uart3_on {
    > + rx {

    This is a friendly reminder during the review process.

    It seems my previous comments were not fully addressed. Maybe my
    feedback got lost between the quotes, maybe you just forgot to apply it.
    Please go back to the previous discussion and either implement all
    requested changes or keep discussing them.

    Thank you.

    6.1-rc3 is not a proper rebase... You *must* include maintainers'
    entries. This *must* align with stuff has Bjorn. Also I expect it passes
    dtbs_check on stuff in the next.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-11-02 20:20    [W:4.125 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site