Messages in this thread Patch in this message | | | From | Coiby Xu <> | Subject | [PATCH] dm-crypt: fix incorrect use of strcmp when telling if there is no key | Date | Mon, 7 Nov 2022 20:22:33 +0800 |
| |
strcmp returns 0 when two strings are equal.
Fixes: 69a8cfcda210 ("dm crypt: set key size early") Signed-off-by: Coiby Xu <coxu@redhat.com> --- drivers/md/dm-crypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 159c6806c19b..cfefe0f18150 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -2590,7 +2590,7 @@ static int crypt_set_key(struct crypt_config *cc, char *key) int key_string_len = strlen(key); /* Hyphen (which gives a key_size of zero) means there is no key. */ - if (!cc->key_size && strcmp(key, "-")) + if (!cc->key_size && !strcmp(key, "-")) goto out; /* ':' means the key is in kernel keyring, short-circuit normal key processing */ -- 2.38.1
| |