Messages in this thread | | | Date | Mon, 7 Nov 2022 12:09:30 +0100 | Subject | Re: [PATCH v3 06/12] drm/mediatek: hdmi: add frame_colorimetry flag | From | AngeloGioacchino Del Regno <> |
| |
Il 04/11/22 15:09, Guillaume Ranquet ha scritto: > Add a flag to indicate support for frame colorimetry. > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > --- > drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 11 +++++++++++ > drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c > index 3635ca66817b..933c51b5f6d7 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c > @@ -120,6 +120,17 @@ int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi, u8 *buffer, size_t bufsz > return err; > } > > + if (hdmi->conf->has_frame_colorimetry) { > + frame.colorimetry = hdmi->colorimtery;
Typo: s/colorimtery/colorimetry/g
...also, I don't see this being really used? In hdmi-v2 you're setting this param to HDMI_COLORIMETRY_NONE and quantization ranges to always the same default value.
I wonder if this is really needed at this point.
Regards, Angelo
| |