lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] driver: gpu: add failure check for ftell
Date
From: shenyanfeng <shenyanfeng@xiaomi.com>

add return-value check of ftell to improve robustness(and avoid abnormal behavior)

Signed-off-by: SPeak <speakshen@163.com>
Signed-off-by: shenyanfeng <shenyanfeng@xiaomi.com>
---


Receive "Undelivered Mail Returned to Sender", so send again


drivers/gpu/drm/radeon/mkregtable.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/mkregtable.c b/drivers/gpu/drm/radeon/mkregtable.c
index 52a7246fe..c31c58e5f 100644
--- a/drivers/gpu/drm/radeon/mkregtable.c
+++ b/drivers/gpu/drm/radeon/mkregtable.c
@@ -193,6 +193,7 @@ static int parser_auth(struct table *t, const char *filename)
regmatch_t match[4];
char buf[1024];
size_t end;
+ long pos;
int len;
int done = 0;
int r;
@@ -228,12 +229,12 @@ static int parser_auth(struct table *t, const char *filename)
last_reg = strtol(last_reg_s, NULL, 16);

do {
- if (fgets(buf, 1024, file) == NULL) {
+ if ((fgets(buf, 1024, file) == NULL) || (pos = ftell(file)) < 0) {
fclose(file);
return -1;
}
len = strlen(buf);
- if (ftell(file) == end)
+ if (pos == end)
done = 1;
if (len) {
r = regexec(&mask_rex, buf, 4, match, 0);
--
2.25.1
\
 
 \ /
  Last update: 2022-11-07 08:37    [W:0.031 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site