lkml.org 
[lkml]   [2022]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings
From
On 04/11/2022 03:28, Md Danish Anwar wrote:
>>> * It includes indentation, formatting, and other minor changes.
>>> ---
>>> .../bindings/net/ti,icssg-prueth.yaml | 181 ++++++++++++++++++
>>> 1 file changed, 181 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>> new file mode 100644
>>> index 000000000000..40af968e9178
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>>> @@ -0,0 +1,181 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/net/ti,icssg-prueth.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: |+
>>
>> Missed Rob's comment.
>>
>
> I'll remove this in the next version of this series.
>
>>> + Texas Instruments ICSSG PRUSS Ethernet
>>> +
>>> +maintainers:
>>> + - Puranjay Mohan <p-mohan@ti.com>
>>> +
>>> +description:
>>> + Ethernet based on the Programmable Real-Time
>>> + Unit and Industrial Communication Subsystem.
>>> +
>>> +allOf:
>>> + - $ref: /schemas/remoteproc/ti,pru-consumer.yaml#
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - ti,am654-icssg-prueth # for AM65x SoC family
>>> +
>>> + pinctrl-0:
>>> + maxItems: 1
>>> +
>>> + pinctrl-names:
>>> + items:
>>> + - const: default
>>
>> You do not need these usually, they are coming from schema.
>>
> Here from what I understand, I need to delete the below block, right?

Yes, entire pinctrl-0 and pinctr-names are not needed. You specify them
ony if they differ from usual.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-11-04 13:57    [W:0.072 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site