lkml.org 
[lkml]   [2022]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] net/mlx5: remove NULL check before dev_{put, hold}
On Wed, 30 Nov 2022 11:00:34 +0200 Leon Romanovsky wrote:
> On Wed, Nov 30, 2022 at 03:41:27PM +0800, zhang.songyi@zte.com.cn wrote:
> > From: zhang songyi <zhang.songyi@zte.com.cn>
> >
> > The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> > so there is no need to check before using dev_{put, hold}.
> >
> > Fix the following coccicheck warning:
> > /drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
> > WARNING:
> > WARNING NULL check before dev_{put, hold} functions is not needed.
> >
> > Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Please change all places in mlx5 in one patch.

Your call as a mlx5 maintainer, but I'd say don't change them at all.
All these trivial patches are such a damn waste of time.

\
 
 \ /
  Last update: 2022-11-30 18:26    [W:0.177 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site