lkml.org 
[lkml]   [2022]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH net-next] net/mlx5: remove NULL check before dev_{put, hold}
On Wed, Nov 30, 2022 at 03:41:27PM +0800, zhang.songyi@zte.com.cn wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold}.
>
> Fix the following coccicheck warning:
> /drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
> WARNING:
> WARNING NULL check before dev_{put, hold} functions is not needed.
>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Please change all places in mlx5 in one patch.

You can find these with the following command
git grep -B 1 -E "dev_put|dev_hold" drivers/net/ethernet/mellanox/mlx5/

Thanks

>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> index 32c3e0a649a7..6ab3a6b6dd8d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> @@ -1448,8 +1448,7 @@ struct net_device *mlx5_lag_get_roce_netdev(struct mlx5_core_dev *dev)
> } else {
> ndev = ldev->pf[MLX5_LAG_P1].netdev;
> }
> - if (ndev)
> - dev_hold(ndev);
> + dev_hold(ndev);
>
> unlock:
> spin_unlock_irqrestore(&lag_lock, flags);
> --
> 2.25.1

\
 
 \ /
  Last update: 2022-11-30 10:02    [W:0.106 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site