Messages in this thread | | | Date | Wed, 30 Nov 2022 10:23:51 +0100 | Subject | Re: [PATCH v3 2/6] dt-bindings: mediatek: modify VDOSYS0 mmsys device tree Documentations for MT8188 | From | AngeloGioacchino Del Regno <> |
| |
Il 29/11/22 15:34, nathan.lu ha scritto: > From: Nathan Lu <nathan.lu@mediatek.com> > > modify VDOSYS0 mmsys device tree Documentations for MT8188. > > Signed-off-by: Nathan Lu <nathan.lu@mediatek.com> > --- > .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > index 0711f1834fbd..3e7fb33201c5 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > @@ -47,6 +47,10 @@ properties: > - const: mediatek,mt2701-mmsys > - const: syscon > > + - items: > + - const: mediatek,mt8188-vdosys0
The devicetree node will be like: something: something@somewhere { compatible = "mediatek,mt8188-vdosys0", "syscon"; .... };
....and will never get any additional compatible string, as when you'll add vdosys1 support, we'll get a similar node like:
something_else: something_else@somewhere_else { comaptible = "mediatek,mt8188-vdosys1", "syscon"; .... };
...so this should go upper in the enum that's listing all of the mediatek,mtXXXX-mmsys compatibles, specifically after `mediatek,mt8186-mmsys`.
Please fix.
Regards, Angelo
| |