Messages in this thread Patch in this message | | | From | Yuri Karpov <> | Subject | [PATCH] net: dsa: fix NULL pointer dereference in seq_match() | Date | Wed, 30 Nov 2022 11:44:31 +0300 |
| |
ptp_parse_header() result is not checked in seq_match() that can lead to NULL pointer dereferense.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: c6fe0ad2c349 ("net: dsa: mv88e6xxx: add rx/tx timestamping support") Signed-off-by: Yuri Karpov <YKarpov@ispras.ru> --- drivers/net/dsa/mv88e6xxx/hwtstamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/hwtstamp.c b/drivers/net/dsa/mv88e6xxx/hwtstamp.c index 331b4ca089ff..97f30795a2bb 100644 --- a/drivers/net/dsa/mv88e6xxx/hwtstamp.c +++ b/drivers/net/dsa/mv88e6xxx/hwtstamp.c @@ -246,7 +246,7 @@ static int seq_match(struct sk_buff *skb, u16 ts_seqid) hdr = ptp_parse_header(skb, type); - return ts_seqid == ntohs(hdr->sequence_id); + return hdr ? ts_seqid == ntohs(hdr->sequence_id) : 0; } static void mv88e6xxx_get_rxts(struct mv88e6xxx_chip *chip, -- 2.34.1
| |