Messages in this thread | | | From | Shinichiro Kawasaki <> | Subject | Re: [PATCH V4 7/8] null_blk: add param to set max write-zeroes sects | Date | Wed, 30 Nov 2022 08:09:50 +0000 |
| |
On Nov 29, 2022 / 15:28, Chaitanya Kulkarni wrote: > Instead of hardcoding value for the maximum write-zeroes sector to > UINT_MAX >> 9, allow user to set the value with newly added module > parameter max_write_zeroes_sectors. > > Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Nit: it would be the better to note in the commit message why the default value is UINT_MAX >> 9. Other than that, looks good.
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
-- Shin'ichiro Kawasaki
| |