Messages in this thread | | | From | Shinichiro Kawasaki <> | Subject | Re: [PATCH V4 2/8] null_blk: code cleaup | Date | Wed, 30 Nov 2022 08:00:59 +0000 |
| |
On Nov 29, 2022 / 15:28, Chaitanya Kulkarni wrote: > Introduce and use two new macros for calculating the page index from > given sector and index (offset) of the sector in the page. > The newly added macros makes code easy to read with meaningful name and > explanation comments attached to it. > > While at it adjust the code in the null_free_sector() to return early > to get rid of the extra identation. > > Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Looks good to me.
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
-- Shin'ichiro Kawasaki
| |