lkml.org 
[lkml]   [2022]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/8] dt-bindings: soc: socionext: Add UniPhier system controller
From
On 29/11/2022 11:35, Kunihiko Hayashi wrote:
> Add devicetree binding schema for the system controller implemented on
> Socionext Uniphier SoCs.
>
> This system controller has multiple functions such as clock control,
> reset control, internal watchdog timer, thermal management, and so on.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext/socionext,uniphier-sysctrl.yaml | 84 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 85 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
> new file mode 100644
> index 000000000000..e966ce1e4b6c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-sysctrl.yaml
> @@ -0,0 +1,84 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/socionext/socionext,uniphier-sysctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier system controller

As Rob's bot pointed, you need to update here examples in other
bindings, so they will pass. Otherwise it is not bisectable change.

> +
> +maintainers:
> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +description: |+
> + System controller implemented on Socionext UniPhier SoCs has multiple
> + functions such as clock control, reset control, internal watchdog timer,
> + thermal management, and so on.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - socionext,uniphier-ld4-sysctrl
> + - socionext,uniphier-pro4-sysctrl
> + - socionext,uniphier-pro5-sysctrl
> + - socionext,uniphier-pxs2-sysctrl
> + - socionext,uniphier-ld6b-sysctrl
> + - socionext,uniphier-sld8-sysctrl
> + - socionext,uniphier-ld11-sysctrl
> + - socionext,uniphier-ld20-sysctrl
> + - socionext,uniphier-pxs3-sysctrl
> + - socionext,uniphier-nx1-sysctrl

All of them can have children or only some?

> + - socionext,uniphier-sysctrl
> + - const: simple-mfd
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + "^clock-controller(@[0-9a-f]+)?$":
> + $ref: /schemas/clock/socionext,uniphier-clock.yaml#
> +
> + "^reset-controller(@[0-9a-f]+)?$":
> + $ref: /schemas/reset/socionext,uniphier-reset.yaml#
> +
> + "^watchdog(@[0-9a-f]+)?$":
> + $ref: /schemas/watchdog/socionext,uniphier-wdt.yaml#
> +
> + "^thermal-sensor(@[0-9a-f]+)?$":
> + $ref: /schemas/thermal/socionext,uniphier-thermal.yaml#
> +

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-11-29 15:42    [W:3.729 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site