Messages in this thread | | | From | Biju Das <> | Subject | RE: [PATCH v2 7/7] drm: rcar-du: dsi: Add r8a779g0 support | Date | Tue, 29 Nov 2022 11:40:12 +0000 |
| |
> -----Original Message----- > From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com> > Sent: 29 November 2022 11:30 > To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>; Rob > Herring <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Geert Uytterhoeven > <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; dri- > devel@lists.freedesktop.org; linux-renesas-soc@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Andrzej Hajda > <andrzej.hajda@intel.com>; Neil Armstrong <neil.armstrong@linaro.org>; > Robert Foss <robert.foss@linaro.org>; Jonas Karlman <jonas@kwiboo.se>; > Jernej Skrabec <jernej.skrabec@gmail.com> > Subject: Re: [PATCH v2 7/7] drm: rcar-du: dsi: Add r8a779g0 support > > On 29/11/2022 03:49, Laurent Pinchart wrote: > > Hi Tomi, > > > > Thank you for the patch. > > > > On Wed, Nov 23, 2022 at 08:59:46AM +0200, Tomi Valkeinen wrote: > >> Add DSI support for r8a779g0. The main differences to r8a779a0 are in > >> the PLL and PHTW setups. > >> > >> Signed-off-by: Tomi Valkeinen > >> <tomi.valkeinen+renesas@ideasonboard.com> > >> --- > >> drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 484 +++++++++++++++- > --- > >> drivers/gpu/drm/rcar-du/rcar_mipi_dsi_regs.h | 6 +- > >> 2 files changed, 384 insertions(+), 106 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > >> b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > >> index a7f2b7f66a17..723c35726c38 100644 > >> --- a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > >> +++ b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c > >> @@ -9,6 +9,7 @@ > >> #include <linux/delay.h> > >> #include <linux/io.h> > >> #include <linux/iopoll.h> > >> +#include <linux/math64.h> > >> #include <linux/module.h> > >> #include <linux/of.h> > >> #include <linux/of_device.h> > >> @@ -28,6 +29,20 @@ > >> #include "rcar_mipi_dsi.h" > >> #include "rcar_mipi_dsi_regs.h" > >> > >> +#define MHZ(v) ((v) * 1000000u) > > > > Isn't the U suffix usually spelled in uppercase ? Same below. > > I couldn't find any coding style guidelines on that. I like the lower > case visually. The suffix stands out much clearer on 10000000u than on > 10000000U. But I can change it if you feel otherwise.
https://elixir.bootlin.com/linux/v6.1-rc7/source/include/linux/units.h#L11
Maybe you could add MHZ here??
Cheers, Biju
| |