Messages in this thread | | | Date | Tue, 29 Nov 2022 20:35:51 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next 1/3] net: pcs: altera-tse: use read_poll_timeout to wait for reset |
| |
On Fri, 25 Nov 2022 14:17:59 +0100 Maxime Chevallier wrote: > - for (i = 0; i < SGMII_PCS_SW_RESET_TIMEOUT; i++) { > - if (!(tse_pcs_read(tse_pcs, MII_BMCR) & BMCR_RESET)) > - return 0; > - udelay(1); > - } > - > - return -ETIMEDOUT; > + return read_poll_timeout(tse_pcs_read, bmcr, (bmcr & BMCR_RESET), > + 10, SGMII_PCS_SW_RESET_TIMEOUT, 1, > + tse_pcs, MII_BMCR);
You say "no functional change intended" in the cover letter but you switch from udelay to usleep and change timeouts here. I presume this is intentional but should be mentioned in the commit message, I think.
| |