lkml.org 
[lkml]   [2022]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/3] iio: add struct declarations for iio types
From


Am 25.11.2022 um 12:01 schrieb Andy Shevchenko:
> On Fri, Nov 25, 2022 at 12:45:06PM +0200, Andy Shevchenko wrote:
>> On Fri, Nov 25, 2022 at 09:35:24AM +0100, Gerald Loacker wrote:
>
> ...
>
>>> +struct iio_val_int_plus_micro {
>>> + int val_int;
>>> + int val_micro;
>>> +};
>
> Thinking more about naming, why not drop val_ completely?
>
> int integer;
> int micro;
>
> ?
>

Yes, this sounds good to me. I think of adding only

typedef struct {
int integer;
int micro;
} iio_val_int_plus_micro;

for now, and one can add similar structures when needed, like

typedef struct {
int integer;
int nano;
} iio_val_int_plus_nano;

or

typedef iio_val_int_plus_micro iio_val_int_plus_micro_db;

If you think it's better to add them all, I can do that, of course.

>>> +struct iio_val_int_plus_nano {
>>> + int val_int;
>>> + int val_nano;
>>> +};
>>> +
>>> +struct iio_val_int_plus_micro_db {
>>> + int val_int;
>>
>> int val_int_db; ?
>>
>>> + int val_micro_db;
>>> +};
>>
>> Actually why can't we simply do
>>
>> typedef iio_val_int_plus_micro_db iio_val_int_plus_micro;
>>
>> ?
>

\
 
 \ /
  Last update: 2022-11-28 13:23    [W:0.064 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site