Messages in this thread | | | Date | Fri, 25 Nov 2022 12:45:06 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 1/3] iio: add struct declarations for iio types |
| |
On Fri, Nov 25, 2022 at 09:35:24AM +0100, Gerald Loacker wrote: > Add structs for iio type arrays such as IIO_AVAIL_LIST which can be used > instead of int arrays.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
And thank you for doing this!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (one comment below)
> Signed-off-by: Gerald Loacker <gerald.loacker@wolfvision.net> > --- > include/linux/iio/iio.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h > index f0ec8a5e5a7a..eaf6727445a6 100644 > --- a/include/linux/iio/iio.h > +++ b/include/linux/iio/iio.h > @@ -383,6 +383,21 @@ s64 iio_get_time_ns(const struct iio_dev *indio_dev); > > struct iio_trigger; /* forward declaration */ > > +struct iio_val_int_plus_micro { > + int val_int; > + int val_micro; > +}; > + > +struct iio_val_int_plus_nano { > + int val_int; > + int val_nano; > +}; > + > +struct iio_val_int_plus_micro_db { > + int val_int;
int val_int_db; ?
> + int val_micro_db; > +};
Actually why can't we simply do
typedef iio_val_int_plus_micro_db iio_val_int_plus_micro;
?
> /** > * struct iio_info - constant information about device > * @event_attrs: event control attributes > -- > 2.37.2 >
-- With Best Regards, Andy Shevchenko
| |