Messages in this thread | | | Date | Tue, 22 Nov 2022 05:29:23 -0500 | From | William Breathitt Gray <> | Subject | Re: [PATCH v3 3/9] gpio: 104-dio-48e: Migrate to the regmap-irq API |
| |
On Wed, Nov 23, 2022 at 05:01:53PM +0200, Andy Shevchenko wrote: > On Tue, Nov 22, 2022 at 02:11:00AM -0500, William Breathitt Gray wrote: > > + /* Initialize device interrupt state */ > > + err = regmap_read(map, DIO48E_DISABLE_INTERRUPT, &val); > > + if (err) > > + return err; > > Use ->init_hw() callback for this.
In a subsequent patch 7/9 we remove direct gpio_chip registration in favor of the i8255 library registration via gpio_regmap. It doesn't look like gpio_regmap_register() sets the init_hw() callback.
Michael, do you see any issues if I introduce init_hw() to gpio_regmap_config? Or do you think this IRQ initialization belongs somewhere else?
William Breathitt Gray [unhandled content-type:application/pgp-signature] | |