Messages in this thread | | | Date | Sat, 26 Nov 2022 15:42:12 +0100 | Subject | Re: [PATCH 00/14] staging: vc04_services: bcm2835-isp support | From | Stefan Wahren <> |
| |
Hi Umang,
Am 21.11.22 um 22:47 schrieb Umang Jain: > This series aims to upport bcm2835-isp from the RPi kernel [1] and is a > independent subset of earlier series [2] posted to upport CSI-2/CCP2 > receiver IP core("Unicam) + the ISP driver found in BCM283x and compatible > SoCs (namely BCM2711). Unicam is still under active development to work > with multistream support to get into mainline. Hence only the ISP driver > will remain the primary area of this series.
thanks for working on this. But honestly i would prefer that vchiq comes out of staging before adding more features. As Greg said some time ago staging is not a place to "dump code and run away". These new files are in the same bad shape as the rest of vc04 before the clean-up here in staging started.
I agree that VCSM is on the TODO list for vchiq, but this driver is not necessary for making bcm2835-audio & bcm2835-camera leave staging. It just binds more resources on a new feature.
Unfortuntately i hadn't much time to work on vchiq by myself.
Just my two cents Stefan
| |