lkml.org 
[lkml]   [2022]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] ALSA: rawmidi: fix infoleak in snd_rawmidi_ioctl_status_compat64
Date
The compat_status is declared off of the stack, so it needs to
be zeroed out before copied back to userspace to prevent any
unintentional data leakage.

Signed-off-by: Xiaolong Huang <butterflyhuangxx@gmail.com>
---
sound/core/rawmidi_compat.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/core/rawmidi_compat.c b/sound/core/rawmidi_compat.c
index 68a93443583c..6afa68165b17 100644
--- a/sound/core/rawmidi_compat.c
+++ b/sound/core/rawmidi_compat.c
@@ -80,6 +80,7 @@ static int snd_rawmidi_ioctl_status_compat64(struct snd_rawmidi_file *rfile,
if (err < 0)
return err;

+ memset(&compat_status, 0, sizeof(compat_status));
compat_status = (struct compat_snd_rawmidi_status64) {
.stream = status.stream,
.tstamp_sec = status.tstamp_sec,
base-commit: eb7081409f94a9a8608593d0fb63a1aa3d6f95d8
--
2.25.1

\
 
 \ /
  Last update: 2022-11-22 21:09    [W:0.046 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site