| Date | Mon, 21 Nov 2022 09:58:41 +0100 | Subject | Re: [PATCH v5 13/14] serial: liteuart: add IRQ support for the TX path | From | Jiri Slaby <> |
| |
On 18. 11. 22, 15:55, Gabriel Somlo wrote: > Switch the TX path to IRQ-driven operation, while maintaining support > for polling mode via the poll timer. > > Signed-off-by: Gabriel Somlo <gsomlo@gmail.com> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> ... > @@ -154,6 +148,8 @@ static irqreturn_t liteuart_interrupt(int irq, void *data) > isr = litex_read8(port->membase + OFF_EV_PENDING) & uart->irq_reg; > if (isr & EV_RX) > liteuart_rx_chars(port); > + if (isr & EV_TX) > + liteuart_tx_chars(port);
Wait, how do you ensure the OFF_EV_PENDING reg contains EV_RX and/or EV_TX in the polling mode?
thanks, -- js suse labs
|