lkml.org 
[lkml]   [2022]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v5 09/14] serial: liteuart: fix rx loop variable types
    From
    On 18. 11. 22, 15:55, Gabriel Somlo wrote:
    > Update variable types to match the signature of uart_insert_char()
    > which consumes them.
    >
    > Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
    > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
    > ---
    > drivers/tty/serial/liteuart.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
    > index 81aa7c1da73c..42ac9aee050a 100644
    > --- a/drivers/tty/serial/liteuart.c
    > +++ b/drivers/tty/serial/liteuart.c
    > @@ -73,8 +73,7 @@ static void liteuart_timer(struct timer_list *t)
    > struct liteuart_port *uart = from_timer(uart, t, timer);
    > struct uart_port *port = &uart->port;
    > unsigned char __iomem *membase = port->membase;
    > - int ch;
    > - unsigned long status;
    > + unsigned int status, ch;

    These should be u8 after all, right?

    Wait, status is a bool in the end:

    > while ((status = !litex_read8(membase + OFF_RXEMPTY)) == 1) {

    But why is it passed to uart_insert_char() as such? That's ugly. Maybe
    drop all of this "status" and pass LSR_RXC directly. The while's
    condition would simply look like (!litex_read8(membase + OFF_RXEMPTY)) then.

    > ch = litex_read8(membase + OFF_RXTX);

    thanks,
    --
    js
    suse labs

    \
     
     \ /
      Last update: 2022-11-21 09:37    [W:2.184 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site