Messages in this thread | | | Date | Mon, 21 Nov 2022 18:50:22 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH v2 net-next 2/3] net: mscc: ocelot: remove unnecessary exposure of stats structures |
| |
On Sat, Nov 19, 2022 at 03:14:05PM -0800, Colin Foster wrote: > diff --git a/drivers/net/ethernet/mscc/ocelot_stats.c b/drivers/net/ethernet/mscc/ocelot_stats.c > index 5dc132f61d6a..68e9f450c468 100644 > --- a/drivers/net/ethernet/mscc/ocelot_stats.c > +++ b/drivers/net/ethernet/mscc/ocelot_stats.c > @@ -460,3 +675,4 @@ void ocelot_stats_deinit(struct ocelot *ocelot) > cancel_delayed_work(&ocelot->stats_work); > destroy_workqueue(ocelot->stats_queue); > } > +
There is a stray blank line at the end of ocelot_stats.c which this patch adds and which doesn't belong. Either you keep this patch set and fix it up later (I don't see another reason to resend except for this), or you resend it. If maintainers don't complain about the new line while the patch gets applied, I'm okay either way.
Anyway,
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
| |