Messages in this thread | | | Subject | Re: [PATCH v2 net-next 2/3] net: mscc: ocelot: remove unnecessary exposure of stats structures | From | Paolo Abeni <> | Date | Tue, 22 Nov 2022 15:54:33 +0100 |
| |
On Sat, 2022-11-19 at 15:14 -0800, Colin Foster wrote: > Since commit 4d1d157fb6a4 ("net: mscc: ocelot: share the common stat > definitions between all drivers") there is no longer a need to share the > stats structures to the world. Relocate these definitions to inside > ocelot_stats.c instead of a global include header. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
I think it's preferable to keep the moved code verbatim as-is instead of additionally fixing the checkpatch warning in the same patch.
The mentioned cleanup could be a follow-up patch - togethar with the trailing empty line removal.
Cheers,
Paolo
| |