lkml.org 
[lkml]   [2022]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 2/4] pwm: Add Apple PWM controller
Date

> Subject: Re: [PATCH v2 2/4] pwm: Add Apple PWM controller
>
> On Wed, 2 Nov 2022 at 19:02, Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
>
> > I just asked, because you are unnecessarily turning on the clock or
> > increasing the usage Count, even if it is not used by anyone during
> probe.
>
> It is used to get the clock rate so it can be used to convert between
> seconds and pwm ticks, and the pwm uses that clock, so it is kept
> enabled while the pwm is active.

You don't need to enable the pwm clock for getting the clock rate.
devm_clk_get() and then get the rate.

Then enable the clk whenever pwm is enabled
And disable the clk whenever pwm is disabled.

Cheers,
Biju
\
 
 \ /
  Last update: 2022-11-02 17:35    [W:0.076 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site