Messages in this thread | | | From | Biju Das <> | Subject | RE: [PATCH v2 2/4] pwm: Add Apple PWM controller | Date | Wed, 2 Nov 2022 16:02:35 +0000 |
| |
> Subject: Re: [PATCH v2 2/4] pwm: Add Apple PWM controller > > On Wed, 2 Nov 2022 at 18:33, Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > > > + if (IS_ERR(clk)) > > > + return PTR_ERR(clk); > > > > What is your use case? > > > > PWM is configured by bootloader intially?? > > > > Or > > > > PWM is configured by Linux not by the bootloader? > > > > Or > > > > Driver needs to support both ?? > > The PWM device itself is configured by linux, but the clock it uses is > the systemwide 24 MHz clock, and that is configured by platform > firmware.
I just asked, because you are unnecessarily turning on the clock or increasing the usage Count, even if it is not used by anyone during probe.
Cheers, Biju
| |