Messages in this thread | | | Date | Wed, 2 Nov 2022 08:24:19 +0100 | From | Greg KH <> | Subject | Re: [PATCH v3] staging: rtl8192e: space formatting fixes in rtl_cam.c |
| |
On Tue, Nov 01, 2022 at 11:29:00PM +0100, Jerom van der Sar wrote: > Fixed a few coding style issues in rtl_cam.c such as double blank lines > and lack of spaces around binary operators.Some other warnings still > remain. These issues were found by scripts/checkpatch.pl. > > This patch helps clean up the rtl8192e driver in staging, making it > easier to read and maintain. > > Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com> > --- > Changes in v3: > - Fixed faulty dot at the end of the patch sign-off. > > Changes in v2: > - Reverted some formatting fixes to make the diff easier to review. > > drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > index 41faeb4b9b9b..d5aaf24a0ddb 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > @@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev) > { > u32 ulcommand = 0; > > - ulcommand |= BIT31|BIT30; > + ulcommand |= BIT31 | BIT30;
Ok, new spaces, nice!
> rtl92e_writel(dev, RWCAM, ulcommand); > } > > @@ -40,7 +40,6 @@ void rtl92e_enable_hw_security_config(struct net_device *dev) > SECR_value |= SCR_TxUseDK; > } > > -
You removed a line?
That's a different type of fix, sorry. Please break this up into a "one logical change per patch" patch series and resend.
thanks,
greg k-h
| |