Messages in this thread | | | Date | Wed, 2 Nov 2022 23:00:17 +0100 | Subject | Re: [PATCH v4] staging: rtl8192e: space formatting fixes in rtl_cam.c | From | Philipp Hortmann <> |
| |
On 11/2/22 21:00, Jerom van der Sar wrote: > Fixed a few coding style issues in rtl_cam.c: two times lack of > spaces around binary operators. Some other warnings still remain. > These issues were found by scripts/checkpatch.pl. > > This patch helps clean up the rtl8192e driver in staging, making it > easier to read and maintain. > > Signed-off-by: Jerom van der Sar <jerom.vandersar@gmail.com> > --- > Changes in v4: > - Reverted more double blank line formatting fixes to make the patch > even smaller. > > Changes in v3: > - Fixed faulty dot at the end of the patch sign-off. > > Changes in v2: > - Reverted some formatting fixes to make the diff easier to review. > > drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > index 41faeb4b9b9b..41bff46d1b3a 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_cam.c > @@ -17,7 +17,7 @@ void rtl92e_cam_reset(struct net_device *dev) > { > u32 ulcommand = 0; > > - ulcommand |= BIT31|BIT30; > + ulcommand |= BIT31 | BIT30; > rtl92e_writel(dev, RWCAM, ulcommand); > } > > @@ -107,7 +107,7 @@ void rtl92e_set_key(struct net_device *dev, u8 EntryNo, u8 KeyIndex, > > for (i = 0; i < CAM_CONTENT_COUNT; i++) { > TargetCommand = i + CAM_CONTENT_COUNT * EntryNo; > - TargetCommand |= BIT31|BIT16; > + TargetCommand |= BIT31 | BIT16; > > if (i == 0) { > TargetContent = (u32)(*(MacAddr+0)) << 16 |
Please rebase. I cannot apply your patch.
Bye Philipp
| |